Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1180 PIN when idle on Android #1191

Merged
merged 1 commit into from
Aug 9, 2023
Merged

fix: #1180 PIN when idle on Android #1191

merged 1 commit into from
Aug 9, 2023

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Aug 8, 2023

Description

Fixes "PIN when idle" feature for Android. Also updates some copy.

Linked Issues/Tasks

Closes #1180

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

QA Notes

Make sure the auth check after 90 seconds if the setting is enabled.

Check that interaction with "Clipboard ease-of-use" and PIN works correctly:

  1. enable clipboard ease-of-use
  • app start / normal -> no redirect
  • app start / with deep link -> should redirect
  • app start / with clipboard data -> should offer redirect
  • app to foreground / normal -> no redirect
  • app to foreground / with deep link -> should redirect
  • app to foreground / with clipboard data -> should offer redirect
  1. enable PIN on launch & PIN when idle
  • app start w/ pinOnLaunch / normal -> should show PIN check
  • app start w/ pinOnLaunch / with deep link -> should show PIN check and redirect
  • app start w/ pinOnLaunch / with clipboard data -> should show PIN check and offer redirect
  • app to foreground w/ pinOnIdle / normal -> should show PIN check
  • app to foreground w/ pinOnIdle / with deep link -> should show PIN check and redirect
  • app to foreground w/ pinOnIdle / with clipboard data -> should show PIN check and offer redirect

@pwltr pwltr requested a review from limpbrains August 8, 2023 14:57
@pwltr pwltr merged commit c3226e0 into master Aug 9, 2023
4 checks passed
@pwltr pwltr deleted the fix/pin-on-idle branch August 9, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Changing 'PIN when idle' setting only takes effect after restart
2 participants